fix: preserve aspect ratio for URL image previews#40399
Open
TasfinMahmud wants to merge 1 commit intoRocketChat:developfrom
Open
fix: preserve aspect ratio for URL image previews#40399TasfinMahmud wants to merge 1 commit intoRocketChat:developfrom
TasfinMahmud wants to merge 1 commit intoRocketChat:developfrom
Conversation
Images shared via URL previews (e.g., Giphy GIFs) were being stretched to fill the Box dimensions independently, causing distorted aspect ratios. Added object-fit: contain and width: auto to MessageGenericPreviewImage so images scale proportionally within the maxHeight constraint. Closes RocketChat#40289
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 73f3993 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughA patch release for ChangesImage Aspect Ratio Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #40289
Images shared via URL previews (e.g., Giphy GIFs) were being stretched to fill the Box dimensions independently, causing distorted aspect ratios.
Checklist